Allow opening a legacy (json) db, and example of migration #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a db which has version
1, we assume it might be using the legacy (json) format. When that happens, the oldrecordstable is dropped, and the newblobsone is created.This of course deletes all cached data (we must update the doc to make this clear).
That is a simple approach appropriate for apps that treat the cache as "only a cache", that can be lost without issues (other than needing to reload data from the network).
As an alternative, the test shows an example of migrating by copying records from a legacy store to the new one. Maybe this could be an API but since it is only a few lines long, and may need some app-specific logic (e.g. copy only certain important records, rather than all of them), I'll leave it as an example for now.